Review main Merged

68930[BUGFIX] Avoid overwriting goToModule in top frame

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 05/04/21, 21:15

Commit message

In case the TYPO3 backend is loaded inside the content frame,
which is a result of a programming error, the inner backend
overwrites state of the outer one, making the backend
unusable because references to javascript singletons
are mixed between outer and inner frame.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Benjamin Franzke uploaded patch set 1 04/30/21, 14:22

  2. core-ci voted on patch set 1 V +1 04/30/21, 14:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10972

  3. Benjamin Franzke uploaded patch set 2 05/04/21, 18:32

  4. core-ci voted on patch set 2 V +1 05/04/21, 18:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11148

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 05/04/21, 19:15

  6. Benni Mack voted on patch set 2 V +2 CR +2 05/04/21, 19:36

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 05/04/21, 21:14

  8. Benjamin Franzke merged patch set 3 05/04/21, 21:15