Review main Merged

68977[BUGFIX] Ensure MountPoint parameter contains valid characters

Benni Mack CR +2 V +2 Normal +70 −0 updated 05/04/21, 09:54

Commit message

When using ?MP=12-13,345-673 some could also add a
letter or a "/" symbol in the GET parameter, effectively
showing a 503 instead of 404 page. This change ensures
that $TSFE->MP only contains numbers, commas or dashes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 05/03/21, 18:41

  2. core-ci voted on patch set 1 V +1 05/03/21, 18:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11064

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 05/03/21, 19:08

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 05/03/21, 20:19

  5. Benni Mack voted on patch set 1 V +2 CR +2 05/04/21, 09:54

  6. Benni Mack merged patch set 2 05/04/21, 09:54