69025[FEATURE] Introduce f:condition.isInstanceOf view-helper
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 56
-
Oliver Hader uploaded patch set 1 05/04/21, 21:03
-
Christian Kuhn commented on patch set 1 05/04/21, 21:15
I'd prefer to move this to dashboard and mark internal since we need it only over there ... an instanceof VH is kinda smelly, don't you think? -
core-ci voted on patch set 1 V +1 05/04/21, 21:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11174
-
Oliver Hader commented on patch set 1 CR -1 05/04/21, 21:43
Probably move to dashboard extension, since it's currently required there only -
Oli Bartsch commented on patch set 1 05/05/21, 08:30
Reply
Let’s also make this internal. As you mention, it’s only needed for the dashboard and should IMO not become public API. -
Oliver Hader abandoned the change 05/05/21, 14:58
Just realized it can be done much simpler...