Review main Merged

69034[TASK] Avoid GeneralUtility::_GET() in EXT:indexed_search

Oli Bartsch CR +2 V +2 Easy +21 −6 updated 05/05/21, 14:16

Commit message

The AdministrationController in EXT:indexed_search is based
on the extbase framework. As this provides a specific request
object, there is no need to use GeneralUtility::_GET() for
fetching plugin related arguments.

However, since the extbase specific request object does not
provide non-plugin related arguments (those without the plugin
prefix), we currently have to fetch them from the global PSR-7
request. This will vanish as soon as extbase does also use the
PSR-7 implementation.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1