Review main Merged

69056[TASK] Streamline backend UriBuilder dependency injection

Benjamin Franzke CR +2 V +2 Normal +40 −14 updated 05/11/21, 18:20

Commit message

The Router dependency should not be optional and rather always be
injected, and in reality it always was, as the nullable fallback
to GeneralUtility::makeInstance was only used in unit tests.

The UriBuilder factory is now provided via the backend
service provider. That is because it became an ondemand
dependency for the backend request handler in #93674.
We now properly inject it via constructor which makes it
a lowlevel service (a service that needs to defined via
service provider to be available when TYPO3 has not yet
been installed).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8