Review main Merged

69058[TASK] Make module requests Sec-Fetch-Dest aware

Benjamin Franzke CR +2 V +2 Normal +78 −53 updated 09/22/21, 11:17

Commit message

This change allows module URLs to be automatically framed by the
TYPO3 main controller whenever they are directly opened in the browser
address bar in a secure environment (e.g. https:// or .localhost TLD)
(In this case the Sec-Fetch-Dest=document is sent by browsers). See:
https://w3c.github.io/webappsec-fetch-metadata/#sec-fetch-dest-header

Note: This header is already supported by Chrome, Edge and
Firefox nightly, only Safari does not deliver this header yet. Non
supporting browsers or unsafe http connections will gracefully fallback
to showing the module contents without the TYPO3 main frame being added.
This fallback behaviour is only triggered when a link is
opened in a new tab. Regular clicks are intercepted and
directly dispatched via module-router/iframe, as before.

This change allows to render the module menu with anchor tags
instead of buttons which lets users decide how and where a
module should be opened.

Long term goal is to improve accessibility by using real
links not only in module menu (as we had in TYPO3 v7), but
actually everywhere (for example in the database record list),
in order for the user to decide whether to open a link in
the current or a new tab.
This will require enhancing FormEngine routes with module
information and is therefore out of scope for this change.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 17