Review main Merged

69060[BUGFIX] Show active page in page tree for shared FormEngine links

Benjamin Franzke CR +2 V +2 Normal +194 −23 updated 10/14/25, 15:33

Commit message

To highlight the current module of an element when opening the TYPO3
backend using a shared link or by reloading, the URL now contains the
current module context and ensures that the module is marked as active
and that the relevant navigation component (page tree or file tree) is
opened and the selected page or file is marked active as well, based on
tree context reinitialization support added in #105120.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 53

Show 33 more files

Review log 3759

Show 2034 earlier messages
  1. Benjamin Franzke uploaded patch set 1 05/06/21, 22:17

  2. core-ci voted on patch set 1 V +1 05/06/21, 22:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11275

  3. Benjamin Franzke uploaded patch set 2 05/07/21, 19:45

  4. core-ci voted on patch set 2 V +1 05/07/21, 19:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11301

  5. Benni Mack wrote 11/29/21, 10:06

    Change destination moved from master to main
  6. Benni Mack updated the commit message in patch set 3 11/29/21, 13:21

  7. core-ci voted on patch set 3 V +1 11/29/21, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20008

  8. Benjamin Franzke uploaded patch set 4 V +1 04/25/25, 17:11

  9. core-ci voted on patch set 4 V -1 04/25/25, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78186

  10. Benjamin Franzke uploaded patch set 5 V -1 04/25/25, 17:36

  11. core-ci voted on patch set 5 V +1 04/25/25, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78187

  12. Benjamin Franzke uploaded patch set 6 V +1 04/26/25, 08:13

  13. core-ci voted on patch set 6 V -1 04/26/25, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78206

  14. Benjamin Franzke uploaded patch set 7 V -1 04/26/25, 16:28

  15. core-ci voted on patch set 7 V -1 04/26/25, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78209

  16. Benjamin Franzke uploaded patch set 8 V -1 04/28/25, 06:39

  17. core-ci voted on patch set 8 V +1 04/28/25, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78264

  18. Benjamin Franzke uploaded patch set 9 V +1 05/27/25, 17:49

  19. core-ci voted on patch set 9 V +1 05/27/25, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79588

  20. Benjamin Franzke uploaded patch set 10 V +1 06/10/25, 13:33

    Rebase
  21. core-ci voted on patch set 10 V +1 06/10/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80149

  22. Benni Mack commented on patch set 10 06/10/25, 22:04

    I wonder if we actually should expand this, and add some more information to this link, and name it "context" instead of module. I had the use-case quite often in the past week that people shared their link when inside e.g. workspace ID=3 editing something, whereas another editor was in workspace ID=5. This was just not possible to deal with properly, and we could actually add this either to the speaking URL, or to the GET parameter, which would call context instead of module?
  23. Benjamin Franzke commented on patch set 10 06/17/25, 06:58

    Reply

    Hm, I don't know honestly, we need to know which context is important for what situation, e.g. workspace is prbably not relevant for bookmarks, since you don't want an implicit workspace switch, if you select a bookmark. Another thing: All modules routes already contain the module as a context, therefore a context-with-module-information would only make sense for non-module routes like FormEngine, the context for module-routes would need to be (should should be) without module information (would be redundant). So if you ask me, I'd like to keep this rather simple and attach only the module information.
  24. Benjamin Franzke uploaded patch set 11 V +1 06/18/25, 09:31

    Rebase
  25. core-ci voted on patch set 11 V +1 06/18/25, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80458

  26. Benni Mack commented on patch set 11 06/26/25, 16:29

    Reply

    fine by me, let's go with your way pls.
  27. Benjamin Franzke uploaded patch set 12 V +1 06/26/25, 16:41

  28. core-ci voted on patch set 12 V +1 06/26/25, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81000

  29. Oli Bartsch uploaded patch set 13 V +1 06/26/25, 19:17

  30. Oli Bartsch uploaded patch set 14 06/26/25, 19:23

  31. core-ci voted on patch set 13 V +1 06/26/25, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81016

  32. Oli Bartsch uploaded patch set 15 06/26/25, 19:30

  33. Oli Bartsch voted on patch set 15 CR +1 V +1 06/26/25, 19:31

  34. core-ci voted on patch set 14 V +1 06/26/25, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81019

  1. core-ci voted on patch set 15 V +1 06/26/25, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81020

  2. Oli Bartsch uploaded patch set 16 CR +1 V +1 06/26/25, 19:56

  3. Oli Bartsch voted on patch set 16 CR +1 V +1 06/26/25, 19:56

  4. core-ci voted on patch set 16 V +1 06/26/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81030

  5. Oli Bartsch commented on patch set 16 CR 0 V 0 07/03/25, 07:46

    Unfortunately, I have to withdraw my votes. While I tried to convince Benni to support this patch, he raised valid concerns about hard-coded module identifiers throughout the system and in third-party code, e.g. via the new VH arguments. I still believe this issue should be addressed soon, and I hope we can find time to work on a more flexible, dynamic approach.
  6. Benjamin Franzke commented on patch set 16 07/03/25, 10:22

    Reply

    Ok, understand, thanks for forwarding. So you personally share these concerns and therefore withdraw your vote(?) Then here's a question for you: What's you take on route identifiers? ;) ``` git grep -l f:be.uri | xargs sed -n "s/.*f:be.uri(route: *'\([^']*\)'.*/\\1/p" | sort | uniq backend_user_management dashboard extensionmanager mfa move_element online_media pagetsconfig_active record_download {routeIdentifier} scheduler_manage setup_mfa site_configuration site_configuration.save site_redirects styleguide_components system_dbint system_reactions tce_file tools_toolssettings tx_impexp_export tx_impexp_import typoscript_active typoscript_active.edit typoscript_active.update user_setup web_FormFormbuilder webhooks_management web_info_overview web_info_translations web_layout web_MyextensionList web_ts web_typoscript_analyzer web_typoscript_constanteditor web_typoscript_infomodify wizard_element_browser workspaces_admin ``` Are they bad as well, since they are hard coded as well.. I mean, I actually don't get it, hardcoded route or module paths are bad, yes, but hardcoded identifiers? That's the idea of identifiers, to be used to reference stuff…
  7. Oli Bartsch commented on patch set 16 07/03/25, 15:24

    Reply

    Sounds fair. Oke, I would like to at least have this patch optimized that no empty "module" arguments are added to the URLs and we might want to add a fallback in EditDocumentController->setModuleContext() to 'web_list` in case no module is given and the user has access to `web_list`. What do you think?

    EditDocumentController.php:488

    ```suggestion $module = $this->module; if ($module === null) { $module = $this->moduleProvider->getModule('web_list', $this->getBackendUser()); if ($module === null) { return; } } $view->setModuleName($module->getIdentifier()); $parent = $module->getParentModule(); ```
  8. Benjamin Franzke commented on patch set 16 07/04/25, 07:43

    Reply

    A fallback would result in a forced module switch to web-list. If a custom module invokes FormEngine without the module argument, the module menu context would then switch to to Web>List, which would be confusing for the user.
  9. Benjamin Franzke uploaded patch set 17 V +1 07/25/25, 11:59

  10. Benjamin Franzke commented on patch set 17 07/25/25, 11:59

    Reply

    Done

    EditDocumentController.php:488 Reply

    No, if there is no module context, we *must* not fallback to web_list, the module menu context would then switch to to Web>List, which would be confusing for the user, if FormEngine was invoked by a module that did not set a context.
  11. core-ci voted on patch set 17 V +1 07/25/25, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82316

  12. Benjamin Franzke rebased onto patch set 18 V +1 07/28/25, 07:11

  13. core-ci voted on patch set 18 V +1 07/28/25, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82407

  14. Benjamin Franzke uploaded patch set 19 V +1 09/25/25, 11:50

  15. core-ci voted on patch set 19 V +1 09/25/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85510

  16. Benjamin Franzke uploaded patch set 20 V +1 10/06/25, 09:16

  17. core-ci voted on patch set 20 V +1 10/06/25, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86066

  18. Benni Mack updated the commit message in patch set 21 V +1 10/14/25, 14:53

  19. Benjamin Franzke updated the commit message in patch set 22 10/14/25, 14:53

  20. core-ci voted on patch set 21 V +1 10/14/25, 15:03 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 22 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86642

  21. core-ci voted on patch set 22 V +1 10/14/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86643

  22. Benni Mack voted on patch set 22 CR +1 V +1 10/14/25, 15:11

  23. Oli Bartsch voted on patch set 22 CR +1 V +1 10/14/25, 15:23

  24. Benjamin Franzke voted on patch set 22 CR +2 V +2 10/14/25, 15:32

  25. Benjamin Franzke merged patch set 23 10/14/25, 15:33