Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
69092[WIP][TASK] Implement install tool layout boilerplate as web components
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/69092/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/92/69092/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Files 29
- Build/Sources/Sass/module/_install.scss+5 −0
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/App.tsnew+226 −0
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/CardButton.tsnew+69 −0
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Install.tsdeleted+0 −28
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module.tsnew+131 −0
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Router.ts+184 −129
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/install/Classes/Controller/AbstractController.php+0 −2
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+66 −2
- typo3/sysext/install/Classes/Controller/LayoutController.php+2 −0
- typo3/sysext/install/Classes/Controller/LoginController.phpdeleted+0 −68
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+90 −2
- typo3/sysext/install/Classes/Controller/SettingsController.php+67 −2
- typo3/sysext/install/Classes/Controller/UpgradeController.php+80 −3
- typo3/sysext/install/Classes/Middleware/Maintenance.php+0 −13
- typo3/sysext/install/Classes/ServiceProvider.php+0 −6
- typo3/sysext/install/Resources/Private/Templates/Environment/Cards.htmldeleted+0 −62
- typo3/sysext/install/Resources/Private/Templates/Layout/Init.html+2 −7
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.htmldeleted+0 −110
- typo3/sysext/install/Resources/Private/Templates/Login/ShowEnableInstallToolFile.htmldeleted+0 −32
Show 9 more files
- typo3/sysext/install/Resources/Private/Templates/Login/ShowLogin.htmldeleted+0 −64
- typo3/sysext/install/Resources/Private/Templates/Maintenance/Cards.htmldeleted+0 −93
- typo3/sysext/install/Resources/Private/Templates/Settings/Cards.htmldeleted+0 −62
- typo3/sysext/install/Resources/Private/Templates/Upgrade/Cards.htmldeleted+0 −91
- typo3/sysext/install/Resources/Public/JavaScript/App.jsnew+139 −0
- typo3/sysext/install/Resources/Public/JavaScript/CardButton.jsnew+15 −0
- typo3/sysext/install/Resources/Public/JavaScript/Install.jsdeleted+0 −13
- typo3/sysext/install/Resources/Public/JavaScript/Module.jsnew+56 −0
- typo3/sysext/install/Resources/Public/JavaScript/Router.js+96 −1
Review log 712
-
Benjamin Franzke uploaded patch set 1 05/07/21, 19:06
-
Benjamin Franzke wrote 05/07/21, 19:11
Topic set to lit -
core-ci voted on patch set 1 V -1 05/07/21, 19:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11297
-
Benjamin Franzke uploaded patch set 2 05/07/21, 21:52
-
core-ci voted on patch set 2 V -1 05/07/21, 22:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11308
-
Benjamin Franzke uploaded patch set 3 05/07/21, 22:22
-
core-ci voted on patch set 3 V +1 05/07/21, 22:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11309
-
Benjamin Franzke uploaded patch set 4 05/26/21, 19:46
-
core-ci voted on patch set 4 V -1 05/26/21, 19:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11883
-
Benni Mack wrote 11/29/21, 10:06
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 5 11/29/21, 13:21
-
core-ci voted on patch set 5 V -1 11/29/21, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20010