Review 10.4 Merged

69119[BUGFIX] Delay error handler registration

Anja Leichsenring CR +2 V +2 Easy +11 −1 updated 05/11/21, 18:33

Commit message

The ErrorHandler is not be fully configured (missing logger) by the
time the object is constructed, but the error handler is registered
at that point. As errors may happen during construction of dependencies
(again the logger) of the ErrorHandler, the error handler registration
needs to be delayed in order to avoid usage of the error handler while
dependencies are still being created. This may happen in case an
exception occurs during creation of the ErrorHandler's logger instances.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Anja Leichsenring commented on patch set 1 05/11/21, 18:16

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 05/11/21, 18:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11387

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 05/11/21, 18:33

  4. Anja Leichsenring merged patch set 2 05/11/21, 18:33