Review main Merged

69144[BUGFIX] Normalize UTF-8 strings before calling CharsetConverter->specCharsToASCII()

Martin Kutschker CR +2 V +2 Easy +31 −3 updated 06/17/21, 11:11

Commit message

The method specCharsToASCII expects its input in Canonical Composition (NFC) otherwise it will produce incorrect results.

The commit also makes sure that a failed normalization (incl. the slug helper) does not lead to data loss.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5