Review main Merged

69173[TASK] Deprecate "relativeToCurrentScript" in FAL API

Benni Mack CR +2 V +2 Normal +143 −12 updated 05/26/21, 13:52

Commit message

The additional argument "relativeToCurrentScript" through
out the File Abstraction Layer is a faulty conceptual
implementation from back in the days.

FAL can only build "relativeToCurrentScript" links for
local drivers (and only in some cases). In addition, we've
successfully migrated all logic in Frontend (Site Handling)
and Backend (URL Routing since TYPO3 v11) to be able to
handle absolute links, so this option should be marked as
deprecated and never be used again, as it does not properly
work if we want a true Abstraction Layer logic.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16