Review main Merged

69181[BUGFIX] Re-calculate z-index of modal and its backdrop

Andreas Kienast CR +2 V +2 Easy +10 −1 updated 05/27/21, 16:40

Commit message

Bootstraps modals are not designed to have multiple instances opened at
once, which was workarounded in TYPO3 a while ago. If a modal overlays
another modal AND is smaller, its backdrop does not overlay the "lower"
modal due to hardcoded z-index values.

With this patch the z-index of both, the modal and its backdrop are
re-calculated depending on the amount of open modals. We use "1000" as
an overall base to circumvent a stuttering UI as Bootstrap uses a z-index
of "1040" for backdrops on initial rendering.
However, this will clash again when at least four modals are open, which
is fine and should never happen - if it does, it at least reveals a
bad UX.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2