69185[TASK] Simplify trimExplode()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1621
-
crell uploaded patch set 1 05/19/21, 14:34
-
core-ci voted on patch set 1 V -1 05/19/21, 14:36 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11679
-
crell marked it work in progress 05/19/21, 14:36
-
Oliver Hader commented on patch set 1 05/19/21, 14:44
GeneralUtility.php:1006UnresolvedReindexing becomes relevant here... -
crell uploaded patch set 2 05/19/21, 17:00
-
core-ci voted on patch set 2 V -1 05/19/21, 17:01 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11682
-
crell marked it ready for review 05/19/21, 17:05
-
crell commented on patch set 2 05/19/21, 17:40
Why the heck doesn't running phpstan locally catch that complaint about fn() vs fn ()?GeneralUtility.php:996Reply`$result = array_values(array_filter(array_map(fn($item) => trim($item) !== '', $result)));` doesn't work either. It actually fails even more tests. :-) -
crell uploaded patch set 3 05/19/21, 17:40
-
core-ci voted on patch set 3 V +1 05/19/21, 17:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11683
-
Christian Kuhn updated the commit message in patch set 4 05/20/21, 14:33
-
core-ci voted on patch set 4 V +1 05/20/21, 14:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11718
-
Christian Kuhn updated the commit message in patch set 5 05/20/21, 15:11
-
core-ci voted on patch set 5 V +1 05/20/21, 15:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11722
-
Christian Kuhn voted on patch set 5 V +1 CR +1 05/20/21, 15:25
-
Jochen Roth voted on patch set 5 V +1 CR +1 05/20/21, 15:26
-
Christian Kuhn voted on patch set 5 V +2 CR +2 05/20/21, 15:27
-
Christian Kuhn merged patch set 6 05/20/21, 15:27
-
Mathias Brodala commented on patch set 6 05/20/21, 16:20
Post -1GeneralUtility.php:979This must be $removeEmptyValues ... -
Oli Bartsch commented on patch set 6 05/20/21, 16:40
GeneralUtility.php:979Reply -
crell commented on patch set 6 05/20/21, 17:07
GeneralUtility.php:979ReplyAck
GeneralUtility.php:996