Review main Merged

69224[TASK] Use codemirror web component for composer proposal

Oli Bartsch CR +2 V +2 Normal +30 −29 updated 05/21/21, 08:36

Commit message

Previously the FormEngine t3editor element was used
for rendering the composer proposal. This however
required to fake TCA, which lead to some misbehaviour,
e.g. in case EXT:t3editor was not installed and FormEngine
automatically fell back to TextElement (see: #94179).

Since t3editor (codemirror) can also be used as a
standalone web component, the FormEngine rendering
is now replaced by directly using the mentioned
component. This results in a less error-prone
implementation and therefore also reduces the risk
of further bugs, in case FormEngine internals change.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1