Review main Merged

69227[BUGFIX] Correctly resolve nested arguments in SimpleEnhancer

Oliver Hader CR +2 V +2 Normal +39 −20 updated 08/25/21, 10:11

Commit message

Having `additionalParams = &simple[id]=okay&simple[other]=other`
with the following route enhancer configuration lead to some flaws:

    routeEnhancers:
      TestSimple:
        type: Simple
        routePath: '/simple/{simple_id}'
        _arguments:
          simple_id: 'simple/id'

* generated URI contained `simple__other`, not resolving nesting
  (`/simple/okay?simple__other=other&cHash=...`)
* `PageArguments::$staticArguments` contained parameter `simple_id`
  (unresolved to actual query parameter, incorrectly marked static)
* other `PageArguments` properties contained `simple__other`
  (unresolved to actual query parameter, ignored nesting)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4