Review main Merged

69229[TASK] Follow best practice on returning PSR-7 response

Oli Bartsch CR +2 V +2 Easy +21 −21 updated 05/26/21, 13:08

Commit message

Since #94186, extbase controller actions are
required to return a PSR-7 response interface.

To ease the use for extension authors, the
helper method `htmlResponse()` was added
to the ActionController. If no data is provided,
$this->view->render() is automatically used
as response body.

This is more or less the usual behaviour of
most extbase actions and therefore also
described in the corresponding RST.

Since core code is often used as example
for custom implementations, those places
should follow the best practices, described
in the RST.

Therefore, this patch adjust all places in core,
which call htmlResponse() and unnecessarily
pass $this->view->render() as data.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8