Review 10.4 Merged

69274[TASK] Better document extbase defaultQuerySettings behavior

Daniel Goerz CR +2 V +2 Easy +11 −2 updated 05/29/21, 18:28

Commit message

Extbase tends to become a victim of its own magic. In this
case, whenever a repository method like initializeObject()
uses setDefaultQuerySettings(), it fully overrides potentially
useful settings created by the factory.
Developers struggle here since all of a sudden things like
storagePid restrictions from configuration are no longer
applied.
We can't change this behavior easily - it would require some
awful dirty handling in QuerySettingsInterface, leading to
even more opaque complexity in this area.
The change adds comments to the property and the setter
hinting about the behavior.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1