Review main Merged

69310[TASK] Deprecate extbase request getBaseUri()

Christian Kuhn CR +2 V +2 Normal +130 −43 updated 05/28/21, 18:35

Commit message

To further prepare extbase towards a extbase Request
object compatible with PSR-7 ServerRequestInterface, we
need some solution for those methods within existing
extbase Request that prevent immutability.

One relatively straight case are setBaseUri() and
getBaseUri(): The setter has been marked @internal in
v10 already and can be dropped, and the getter is used
just in a couple of cases.

The patch adapts usages of getBaseUri() to implement
the uri retrieval on their own based on the PSR-7
request (global access as temporary solution) and
deprecates the method. The setter is dropped.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9