Review main Merged

69315[TASK] Deprecate f:base ViewHelper

Christian Kuhn CR +2 V +2 Easy +43 −3 updated 05/30/21, 17:35

Commit message

The BaseViewHelper which renders a base tag is kinda
useless in our scope: Fluid based rendering typically
takes care of markup within body tag, but base must
be in head.
In frontend, a base tag is thus almost always set using
TypoScript config.baseURL, ending up in PageRenderer.
The backend does stuff like this on a different level,
usually ending up in the PageRenderer as well.
Even with HTML mails, a base tag is uncommon and would
usually - at least in the frontend - again render via
PageRenderer.
The patch deprecates BaseViewHelper.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3