Review main Merged

69326[TASK] Reduce ObjectManager->get() usages in ext:form

Christian Kuhn CR +2 V +2 Hard +91 −286 updated 05/30/21, 18:01

Commit message

ext:form is full of ObjectManager usages. This first
patch tackles a series of simple cases: Mostly things
we know can be created via makeInstance() easily or
can be injected and that are easy to test since errors
would lead to immediate BE module or FE plugin fatals.

Some places benefit by switching to DI, and the
patch does this in some cases. Some other parts are
harder to switch, for instance because they'd require
a bigger test rewrite, or raise b/w compat issues.
Those places simply switch from ObjectManager->get()
to makeInstance() for now.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 24

Show 4 more files