Review main Merged

69360[BUGFIX] Add returnUrl for Open Documents/Recently Used Documents

Jochen Roth CR +2 V +2 Easy +2 −1 updated 07/07/23, 12:47

Commit message

A click on open/recently used documents the returnUrl was not set
which led to a blank content frame when the close button on the
record was clicked.

This issue is fixed by adding the EditDocumentController's returnUrl to
the OpenDocs payload and re-using it in the toolbar items. However, this
will not work with already existing entries and a consistent behavior
cannot be assured due to potentially (dis)allowed modules for each
backend user.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jörg Bösche +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2938

Show 1013 earlier messages
  1. Jochen Roth uploaded patch set 1 06/01/21, 17:26

  2. core-ci voted on patch set 1 V +1 06/01/21, 17:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12093

  3. Riccardo De Contardi commented on patch set 1 V +1 06/06/21, 14:22

    I tested with various types of content, including the ones in the [root] folder, like BE users and it seems to work; I've found just an inconsistency (but it could be a more general interface problem) which is this one: 1) Switch to a draft workspace 2) Create a page (so that, so far, the page DOES NOT EXIST in LIVE workspace) 3) change something if you like and save it 4) switch to LIVE workspace 5) The page is listed in the "Recent documents" dropdown AND CAN BE EDITED 6) this leads to a page that seems to exist on LIVE workspace, even if it is not there and can lead to various errors (for example trying to save it)
  4. Oli Bartsch commented on patch set 1 CR -1 06/07/21, 08:02

    As discussed this needs to be more generic and should also work for bookmarks.
  5. Christian Kuhn commented on patch set 1 11/09/21, 19:39

    ping on status? finish / abandon & reject?
  6. Benni Mack updated the commit message in patch set 2 11/18/21, 10:46

  7. core-ci voted on patch set 2 V +1 11/18/21, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19466

  8. Christian Kuhn commented on patch set 2 CR -1 11/28/21, 00:06

    I agree rendering an empty page is currently imperfect. With the patch if have the following situation: * go to list module * open a tt_content record * go to list module (not closing record) -> opendocs shows 1 open document * open that record in opendocs toolbar item * close that record -> i'm now in the page module. that's odd. i'd expect to be back in the list module where i came from. Unsure if we can solve that, but the patch somehow feels as if it doesn't really solve the usability issue.
  9. Benni Mack wrote 11/29/21, 10:22

    Change destination moved from master to main
  10. Benni Mack updated the commit message in patch set 3 11/29/21, 11:57

  11. core-ci voted on patch set 3 V +1 11/29/21, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19980

  12. Simon Schaufelberger uploaded patch set 4 06/13/22, 23:44

  13. Simon Schaufelberger voted on patch set 4 V +1 CR +1 06/13/22, 23:46

  1. Simon Schaufelberger commented on patch set 4 06/13/22, 23:49

    Reply

    This issue is still open but better go to the page module than an empty page. That is at least an improvement.
  2. core-ci voted on patch set 4 V +1 06/13/22, 23:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28030

  3. Andreas Kienast commented on patch set 4 06/24/22, 11:05

    on it
  4. Andreas Kienast voted on patch set 4 CR -1 06/24/22, 11:05

  5. Andreas Kienast commented on patch set 4 06/24/22, 11:24

    A major in this patch is that backend users may have no access to the page module.
  6. Andreas Kienast uploaded patch set 5 06/24/22, 11:28

  7. Andreas Kienast uploaded patch set 6 06/24/22, 11:29

  8. core-ci voted on patch set 5 V +1 06/24/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28384

  9. core-ci voted on patch set 6 V +1 06/24/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28385

  10. Guido Schmechel voted on patch set 6 V +1 CR +1 07/08/22, 22:31

  11. Simon Schaufelberger commented on patch set 6 08/12/22, 12:14

    Reply Unresolved

    should we also store the module then in the recently used documents so that we know exactly where the user came from?
  12. Nikita Hovratov voted on patch set 6 V +1 08/12/22, 15:55

  13. Nikita Hovratov commented on patch set 6 08/12/22, 15:56

    Can someone mark currently open comments as resolved, if they are please?
  14. Benni Mack updated the commit message in patch set 7 CR +1 V +1 05/03/23, 09:32

  15. Oliver Hader rebased onto patch set 8 05/03/23, 11:53

  16. core-ci voted on patch set 8 V +1 05/03/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41516

  17. Benni Mack commented on patch set 8 07/06/23, 10:20

    Reply

    Done

    Reply

    Done
  18. Benni Mack rebased onto patch set 9 V +1 07/06/23, 10:20

  19. core-ci voted on patch set 9 V +1 07/06/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43684

  20. core-ci commented on patch set 9 07/06/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43684

  21. Susi Moog voted on patch set 9 V +1 CR +1 07/07/23, 11:11

  22. Andreas Kienast voted on patch set 9 V +1 CR +1 07/07/23, 12:24

  23. Jörg Bösche voted on patch set 9 CR +1 07/07/23, 12:32

  24. Andreas Kienast voted on patch set 9 V +2 CR +2 07/07/23, 12:47

  25. Andreas Kienast merged patch set 10 07/07/23, 12:47