Review main Merged

69361[BUGFIX] No greedy Symfony DI in ext:install

Christian Kuhn CR +2 V +2 Easy +8 −3 updated 06/01/21, 18:37

Commit message

We recently added a Services.yaml to ext:install.
This isn't an incredible great idea since the
install tool is designed to work with uncached DI
via ServiceProviders in general.

The config made Symfony scan all classes, but
we need Symfony DI for the backend adapter class only.
The patch reduces Symfony DI registration down to this class.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1