Review main Merged

69419[TASK] Avoid ObjectManager in ext:fluid ViewHelperResolver

Christian Kuhn CR +2 V +2 Hard +213 −54 updated 06/17/21, 18:59

Commit message

Finish the ObjectManager usages in ext:fluid. With #94285
we made the ViewHelperResolver a singleton service, which
is not ok since it holds state: Namespaces are added at
runtime and they additionally depend on request.
The solution is similar to RenderingContext from #94285
though: Have a factory to create fresh instances for
each parsing cycle for this failsafe mode enabled class.
View helper instance prototypes itself are then retrieved
using GeneralUtility::makeInstance().

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 8