Review main Merged

69424[BUGFIX] Always return unique field list

Oli Bartsch CR +2 V +2 Normal +114 −15 updated 06/10/21, 09:31

Commit message

The method DatabaseRecordList::makeFieldList()
creates a list of fields to select for a table. Since
selector.

This method however automatically adds some
management fields, such as `crdate`. As those
fields may also be included in TCA `columns`,
e.g. for sys_redirects since #94143, they may
be added multiple times, which leads to different
errors.

This is now fixed by applying array_unique to the
final field list.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 710

  1. Oli Bartsch uploaded patch set 1 06/09/21, 22:35

  2. Oli Bartsch updated the commit message in patch set 2 06/09/21, 22:36

  3. Oli Bartsch commented on patch set 2 CR -1 06/09/21, 22:42

    Will do some cosmetics and unit test.
  4. core-ci voted on patch set 1 V +1 06/09/21, 22:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12255

  5. core-ci voted on patch set 2 V +1 06/09/21, 22:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12257

  6. Oli Bartsch uploaded patch set 3 06/10/21, 09:20

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 06/10/21, 09:25

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 06/10/21, 09:29

  9. Daniel Goerz merged patch set 4 06/10/21, 09:29

  10. core-ci voted on patch set 3 V +1 06/10/21, 09:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12262