Review main Merged

69453[BUGFIX] Replace all-embracing form in recordlist

Oli Bartsch CR +2 V +2 Normal +67 −68 updated 06/11/21, 08:40

Commit message

All tables were previously wrapped by one form in
the recordlist. Since #94218 this leads to problems
because all tables now define another form for the
"Show columns" selector. Nested forms are invalid
markup. Therefore, effectively only the first table
was wrapped by the general form. The remaining
tables were not longer wrapped into a form, leading
to problems when using the clipboard actions.

This is now fixed by replacing the all-embracing
form with dedicated forms for each displayed table.

Besides fixing the mentioned problems, this change
results in further improvements:

* The forms are now dedicated to their table
* The "Show columns" selector does not longer
need to define a form itself
* When updating the "Show columns" selection
or when executing a clipboard action, the recordlist
jumps to the correct table after reload, using an
anchor tag
* The clipboard related JavaScript can be simplified
in an follow-up patch

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 8