Review main Merged

69470[TASK] Deprecate extbase setDispatched() and isDispatched()

Christian Kuhn CR +2 V +2 Normal +96 −15 updated 06/22/21, 10:55

Commit message

Extbase Request setDispatched() and isDispatched()
violate the PSR-7 'immutable' concept and need to fall.

With the changes from #92502 where extbase actions
usually return a ResponseInterface, together with the
deprecation of StopActionException in #94351, we don't
need this information in the Request anymore: It can
be handled internally within the dispatcher, depending
on the type of the response.

The patch deprecates the two methods in extbase request
and adapts usages towards an internal flag. We
throw a deprecation warning since the flag is needed for
b/w compat in v11, though.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 7