69479[TASK] Raise typo3/cms-styleguide:~11.3.0
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 3
Review log 58
-
Christian Kuhn uploaded patch set 1 06/13/21, 00:40
-
Christian Kuhn rebased onto patch set 2 06/13/21, 00:41
-
core-ci voted on patch set 1 V +1 06/13/21, 00:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12358
-
core-ci voted on patch set 2 V +1 06/13/21, 00:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12360
-
Christian Kuhn rebased onto patch set 3 06/13/21, 01:09
-
core-ci voted on patch set 3 V +1 06/13/21, 01:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12363
-
Christian Kuhn commented on patch set 3 V +2 CR +2 06/13/21, 01:23
I hope it's ok to merge this right away: The php 8 fix reduces the core ac test fails significantly and we're actively working on this. Since this is a --dev dependency, and the changes in styleguide should be safe, it sholud be ok to bend rules a bit here and bring this in, quickly. Slap me if you disagree ;) -
Christian Kuhn merged patch set 4 06/13/21, 01:23