Review main Merged

69486[BUGFIX] Use correct slide direction in MultiStepWizard

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 06/14/21, 13:02

Commit message

Bootstrap beta3 introduced a regression, which reversed
the slide direction. This therefore broke our implementation,
since we are using an event listener, evaluating the direction.

Because we were not aware of this being "just" a regression
instead of an intended API change, we switched the direction
in our event listener in #94037, too.

In the final 5.0 release, we updated to in #94089, the regression
has been fixed, breaking our event listener once again.

This is fixed by restoring the initial and correct direction check.

Related bootstrap PRs:

- https://github.com/twbs/bootstrap/pull/32913
- https://github.com/twbs/bootstrap/pull/33499

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2