Review main Merged

69491[TASK] Avoid 'meta http-equiv="refresh"' in extbase redirectToUri()

Christian Kuhn CR +2 V +2 Easy +7 −9 updated 06/14/21, 21:20

Commit message

"<html><head><meta http-equiv="refresh" ..." is discouraged
by w3.org [1] and should be implemented as server-side 3**
response.
Extbase redirectToUri() already sets 303 (default) and adds
the Location header.
The meta http refresh is obsolete and can be dropped
together with the delay argument.

[1] https://www.w3.org/TR/WCAG20-TECHS/H76.html

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 06/14/21, 15:53

  2. core-ci voted on patch set 1 V +1 06/14/21, 16:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12424

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/14/21, 18:13

  4. Richard Haeser commented on patch set 1 06/14/21, 18:46

    ActionController.php:961

    Just for my information: why don't we deprecate this parameter so we can remove it in a future version?
  5. Christian Kuhn commented on patch set 1 06/14/21, 21:15

    ActionController.php:961 Reply

    due to the third argument - both are optional int's, we can't detect easily if 'old' or 'new' version is used (delay = 303 ...) dunno how do deprecate / migrate this, and wanted to keep the patch simple. maybe simply a breaking change for v12, unsure. we may come back later to this, but i want another patch on this method, so i wanted to keep this patch simple.
  6. Richard Haeser commented on patch set 1 V +2 CR +2 06/14/21, 21:20

    ActionController.php:961 Reply

    ah sure. Didn’t think about that.
  7. Richard Haeser merged patch set 2 06/14/21, 21:20