Review main Merged

69493[BUGFIX] Avoid crash due to endless loop in Fluid-based Page Module

Oliver Hader CR +2 V +2 Easy +3 −3 updated 07/09/21, 08:06

Commit message

Page Module partial `PageLayout/Record/Preview` tries to render optional
`PageLayout/Record/{item.record.CType}/Preview` and falls back to a raw
representation if that custom partial does not exist.

In case `CType` is empty, this resolves to `PageLayout/Record//Preview`
which is actually using `PageLayout/Record/Preview.html` again - that's
the partial again that initiated the process - which will after some
seconds crash due to an endless loop of that partial.

In order to make things explicit, the defaults are now located in
their dedicated namespace `RecordDefault` to avoid ambiguity.

* `PageLayout/Record/Preview` -> `PageLayout/RecordDefault/Preview`
* `PageLayout/Record/Header` -> `PageLayout/RecordDefault/Header`
* `PageLayout/Record/Footer` -> `PageLayout/RecordDefault/Footer`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Oliver Hader uploaded patch set 1 06/14/21, 16:43

  2. Oliver Hader updated the commit message in patch set 2 06/14/21, 16:44

  3. core-ci voted on patch set 1 V +1 06/14/21, 16:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12428

  4. core-ci voted on patch set 2 V +1 06/14/21, 16:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12429

  5. Benni Mack voted on patch set 2 V +1 CR +1 07/09/21, 07:43

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 07/09/21, 08:06

  7. Andreas Kienast merged patch set 3 07/09/21, 08:06