Review main Merged

69544[BUGFIX] Undefined array key in ElementInformation

Jochen Roth CR +2 V +2 Normal +99 −1 updated 06/24/21, 18:34

Commit message

A click on inline fal ElementInformation button leads to
Undefined array key "returnUrl".
Fixed by adding empty string as fallback and add an
acceptance test to make sure it will not appear again.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Jochen Roth uploaded patch set 1 06/23/21, 14:39

  2. core-ci voted on patch set 1 V +1 06/23/21, 14:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12693

  3. Oli Bartsch commented on patch set 1 06/23/21, 14:57

    Please have a look at https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#summary-line-first-line Also "info button" seems a bit to general. TYPO3 provides tons of info buttons, triggering different functionality. This however is about the ElementInformation.
  4. Jochen Roth updated the commit message in patch set 2 06/23/21, 15:08

  5. Jochen Roth commented on patch set 2 CR +1 06/23/21, 15:09

    Reply

    Done
  6. Jochen Roth wrote 06/23/21, 15:09

    Removed Code-Review+1 by Jochen <rothjochen@gmail.com>
  7. core-ci voted on patch set 2 V +1 06/23/21, 15:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12694

  8. Benni Mack voted on patch set 2 V +1 CR +1 06/24/21, 13:54

  9. Jochen Roth updated the commit message in patch set 3 06/24/21, 16:36

  10. Jochen Roth updated the commit message in patch set 4 06/24/21, 16:41

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 06/24/21, 16:43

  12. core-ci voted on patch set 3 V +1 06/24/21, 18:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12714

  13. core-ci voted on patch set 4 V +1 06/24/21, 18:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12715

  14. Georg Ringer voted on patch set 4 V +2 CR +2 06/24/21, 18:34

  15. Georg Ringer merged patch set 5 06/24/21, 18:34