69576[BUGFIX] Access to not defined array key in install tool
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Simon Gilli uploaded patch set 1 06/25/21, 16:28
-
core-ci voted on patch set 1 V +1 06/25/21, 16:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12750
-
crell commented on patch set 1 CR +1 06/25/21, 17:29
Code all looks correct to me. And it even adds proper types. 😊 -
Christian Kuhn commented on patch set 1 06/27/21, 08:16
FlashMessageQueue.php:209Unresolvedcould have a hint or warning this construct is used in install tool context where be_user and fe_user aren't set. -
Christian Kuhn uploaded patch set 2 06/27/21, 13:21
-
Christian Kuhn voted on patch set 2 V +1 CR +1 06/27/21, 13:21
-
Christian Kuhn commented on patch set 2 06/27/21, 13:22
had a similar patch lying around ... -
core-ci voted on patch set 2 V +1 06/27/21, 13:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12762
-
Jochen Roth voted on patch set 2 V +1 CR +1 06/27/21, 13:44
-
Christian Kuhn voted on patch set 2 V +2 CR +2 06/27/21, 13:55
-
Christian Kuhn merged patch set 3 06/27/21, 13:55