Review TYPO3_4-6 Merged

6958[BUGFIX] Invalid query part on menu rendering

Markus Klein CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

Each page can have a target defined, which can also be a
typeNum that gets added to the generated URL. Now if RealURL
is used, the "&type=" part will be just added to the final
URL which looks like "page.html&type=1". A question mark
is missing here to get a valid query part.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Simon Schaufelberger +1
  • Verified V +2
    • Oliver Hader +2
    • Simon Schaufelberger +1

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 12/19/11, 19:40

    Looks good to me, but someone else must approve
  2. Markus Klein commented on patch set 1 12/19/11, 19:40

    Already merged in master.
  3. Oliver Hader commented on patch set 2 12/19/11, 19:40

    Verified; Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-6 - Please consider updating your reviews V:1, R:1 as a summary of previous scores (limited to [-1;+1]) V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:1, R:1 from Simon Schaufelberger <simonschaufi@googlemail.com>
  4. Oliver Hader uploaded patch set 2 12/19/11, 19:40

  5. Simon Schaufelberger commented on patch set 1 12/19/11, 19:40

    Verified; Looks good to me, but someone else must approve
  6. Simon Schaufelberger commented on patch set 2 12/19/11, 19:40

    Verified; Looks good to me, but someone else must approve
  7. Oliver Hader commented on patch set 2 V 0 12/19/11, 19:40

    by team member; Looks good to me, approved
  8. Oliver Hader merged patch set 2 12/19/11, 19:40