Review TYPO3_4-4 Merged

6960[BUGFIX] Invalid query part on menu rendering

Markus Klein CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

Each page can have a target defined, which can also be a
typeNum that gets added to the generated URL. Now if RealURL
is used, the "&type=" part will be just added to the final
URL which looks like "page.html&type=1". A question mark
is missing here to get a valid query part.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Stefan Neufeind +1
    • Simon Schaufelberger +1
  • Verified V +2
    • Oliver Hader +2
    • Simon Schaufelberger +1

Files 1

Review log 5

  1. Stefan Neufeind commented on patch set 1 12/19/11, 19:41

    Looks good to me, but someone else must approve
  2. Markus Klein commented on patch set 1 12/19/11, 19:41

    Already merged in master.
  3. Oliver Hader commented on patch set 1 V 0 12/19/11, 19:41

    by team member; Looks good to me, approved
  4. Simon Schaufelberger commented on patch set 1 12/19/11, 19:41

    Verified; Looks good to me, but someone else must approve
  5. Oliver Hader merged patch set 1 12/19/11, 19:41