Review main Merged

69674[TASK] Replace access to global request in extbase controllers

Oli Bartsch CR +2 V +2 Normal +15 −37 updated 06/30/21, 20:43

Commit message

Since #94428, the extbase Request implements the
PSR-7 ServerRequestInterface. Therefore, all usages
of $GLOBALS['TYPO3_REQUEST'] in core extbase
controllers are now replaced by accessing the extbase
Request object instead.

Since the extbase RequestInterface does not yet
extend the PSR-7 ServerRequestInterface, as this
would be a breaking change, the property type
annotation of $request is changed to the specifc
Request implementation, to still allow IDE support.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 6