Review main Merged

69715[BUGFIX] Prevent method call on invalid task in scheduler

Lukas Niestroj CR +2 V +2 Easy +4 −4 updated 08/09/21, 11:49

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2027

Show 12 earlier messages
  1. Lukas Niestroj uploaded patch set 1 07/05/21, 10:40

  2. core-ci voted on patch set 1 V +1 07/05/21, 10:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12967

  1. Geert Boetzkes voted on patch set 1 CR +1 07/07/21, 09:09

  2. Guido Schmechel voted on patch set 1 CR +1 07/16/21, 15:46

  3. Lukas Niestroj commented on patch set 1 07/20/21, 11:07

    Hi reviewers! This is my very first contribution. Am I missing something? - Lukas
  4. Christian Kuhn updated the commit message in patch set 2 07/29/21, 20:55

  5. Christian Kuhn rebased onto patch set 3 07/29/21, 20:55

  6. Christian Kuhn commented on patch set 3 07/29/21, 20:56

    Looks legit, Lukas. Just applied minor cosmetics to the commit message. Great job for a first patch. Thank you!
  7. Christian Kuhn voted on patch set 3 V +1 CR +1 07/29/21, 20:57

  8. Oli Bartsch voted on patch set 3 CR +1 07/29/21, 21:01

  9. core-ci voted on patch set 2 V -1 07/29/21, 21:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13903

  10. core-ci voted on patch set 3 V -1 07/29/21, 21:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13904

  11. core-ci voted on patch set 3 V +1 07/29/21, 21:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13904

  12. Guido Schmechel voted on patch set 3 CR +1 07/30/21, 23:00

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 08/08/21, 15:16

  14. Christian Kuhn commented on patch set 3 08/08/21, 15:18

    Sorry for the delay, I've been waiting for a missing +1 testing. Hope we'll get that soon since the change is codewise straight.
  15. Jochen Roth voted on patch set 3 V +1 08/08/21, 18:45

  16. Lukas Niestroj uploaded patch set 4 08/09/21, 07:34

  17. core-ci voted on patch set 4 V +1 08/09/21, 07:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14297

  18. Christian Kuhn updated the commit message in patch set 5 08/09/21, 08:38

  19. Christian Kuhn rebased onto patch set 6 08/09/21, 08:38

  20. Jochen Roth voted on patch set 6 V +1 CR +1 08/09/21, 08:38

  21. core-ci voted on patch set 5 V +1 08/09/21, 08:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14306

  22. core-ci voted on patch set 6 V +1 08/09/21, 08:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14307

  23. Christian Kuhn voted on patch set 6 V +2 CR +2 08/09/21, 08:57

  24. Christian Kuhn merged patch set 7 08/09/21, 08:57

  25. Lukas Niestroj commented on patch set 7 08/09/21, 11:49

    Reply

    No Problem. I think I messed up your last rename with my push on a different issue. Sorry!