Review main Merged

69717[TASK] Remove duplicated button in Edit File dialog

Jochen Roth CR +2 V +2 Normal +87 −18 updated 07/06/21, 13:50

Commit message

The button "save and close" is removed because
"save" button does exactly the same thing.
To streamline behavior the save button also
returns to edit file view instead of returning
file list view.

On top of that add a test to cover such redirect
issues in the future.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1218

  1. Jochen Roth uploaded patch set 1 07/05/21, 14:39

  2. core-ci voted on patch set 1 V +1 07/05/21, 14:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12972

  3. Jochen Roth updated the commit message in patch set 2 07/05/21, 14:57

  4. Benni Mack updated the commit message in patch set 3 07/05/21, 15:04

  5. core-ci voted on patch set 2 V +1 07/05/21, 15:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12973

  6. core-ci voted on patch set 3 V +1 07/05/21, 15:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12974

  7. Benni Mack voted on patch set 3 V +1 CR +1 07/05/21, 15:23

  8. Jochen Roth uploaded patch set 4 07/06/21, 08:25

  9. core-ci voted on patch set 4 V -1 07/06/21, 08:36 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12999

  10. Jochen Roth commented on patch set 4 07/06/21, 09:19

  11. Jochen Roth uploaded patch set 5 07/06/21, 11:55

  12. core-ci voted on patch set 5 V +1 07/06/21, 12:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13005

  13. Benni Mack voted on patch set 5 V +1 CR +1 07/06/21, 12:42

  14. Benni Mack updated the commit message in patch set 6 07/06/21, 12:43

  15. Benni Mack voted on patch set 6 V +1 CR +1 07/06/21, 12:43

  16. core-ci voted on patch set 6 V +1 07/06/21, 12:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13007

  17. Oli Bartsch voted on patch set 6 V +2 CR +2 07/06/21, 13:50

  18. Oli Bartsch merged patch set 7 07/06/21, 13:50