Review main Merged

69719[BUGFIX] Prevent bootstrap from removing empty csh popover content

Nikita Hovratov CR +2 V +2 Easy +16 −4 updated 08/10/21, 14:40

Commit message

Since bootstrap v5.0.2 the popover module removes empty title and
content html nodes. This plays however against our strategy to load csh
text on demand. To prevent the automatic removal, an empty p-tag is set
in the data-bs-content attribute.

In addition this fixes another two small bugs:
1. Remove the unexpected argument in the setContent method.
2. Add a new update method in Popover to update the arrow position after
fetching csh text.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5