Review main Merged

69753[FEATURE] Add FAL support for FlexFormProcessor

Simon Gilli CR +2 V +2 Hard +440 −15 updated 09/18/23, 21:35

Commit message

Support for FAL references in FlexForms is added to the
FlexFormProcessor. No additional processing is needed
anymore to resolve FAL references.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Göran Bodenschatz +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 5582

Show 3657 earlier messages
  1. Simon Gilli uploaded patch set 1 07/07/21, 11:40

  2. Simon Gilli uploaded patch set 2 07/07/21, 11:44

  3. core-ci voted on patch set 1 V +1 07/07/21, 11:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13053

  4. Simon Gilli uploaded patch set 3 07/07/21, 12:00

  5. Simon Gilli marked it ready for review 07/07/21, 12:00

  6. core-ci voted on patch set 2 V +1 07/07/21, 12:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13056

  7. Andreas Kienast commented on patch set 3 CR -1 07/07/21, 12:06

    Can you please add another test case to FlexFormProcessorTest.php?
  8. Simon Gilli uploaded patch set 4 07/07/21, 12:10

  9. Simon Gilli uploaded patch set 5 07/07/21, 12:10

  10. Simon Gilli marked it work in progress 07/07/21, 12:12

  11. Simon Gilli commented on patch set 5 07/07/21, 12:12

    Reply

    Yes, will do....
  12. core-ci voted on patch set 3 V +1 07/07/21, 12:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13057

  13. core-ci voted on patch set 4 V +1 07/07/21, 12:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13058

  14. core-ci voted on patch set 5 V +1 07/07/21, 12:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13059

  15. Simon Gilli uploaded patch set 6 07/07/21, 18:36

  16. Simon Gilli uploaded patch set 7 07/07/21, 18:38

  17. core-ci voted on patch set 6 V +1 07/07/21, 18:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13083

  18. Simon Gilli uploaded patch set 8 07/07/21, 18:50

  19. Simon Gilli commented on patch set 8 07/07/21, 18:50

    This change is ready for review.

    Reply

    Done
  20. core-ci voted on patch set 7 V -1 07/07/21, 18:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13084

  21. Simon Gilli uploaded patch set 9 07/07/21, 19:00

  22. core-ci voted on patch set 8 V +1 07/07/21, 19:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13085

  23. core-ci voted on patch set 9 V +1 07/07/21, 19:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13087

  24. Simon Gilli commented on patch set 10 07/08/21, 11:44

    Published edit on patch set 9.
  25. core-ci voted on patch set 10 V +1 07/08/21, 11:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13104

  26. Nikita Hovratov uploaded patch set 11 08/02/21, 15:38

  27. core-ci voted on patch set 11 V +1 08/02/21, 16:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14004

  28. Nikita Hovratov voted on patch set 11 CR +1 08/02/21, 16:12

  29. Benni Mack wrote 11/29/21, 10:14

    Change destination moved from master to main
  30. Benni Mack updated the commit message in patch set 12 11/29/21, 13:38

  31. core-ci voted on patch set 12 V +1 11/29/21, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20065

  32. Jörg Bösche voted on patch set 12 CR +1 01/09/22, 20:39

  33. Simon Schaufelberger uploaded patch set 13 05/29/22, 23:56

  34. core-ci voted on patch set 13 V -1 05/30/22, 00:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27571

  35. Stefan Bürk commented on patch set 14 05/30/22, 07:18

    Published edit on patch set 13.
  36. core-ci voted on patch set 14 V +1 05/30/22, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27579

  37. Simon Schaufelberger voted on patch set 14 V +1 CR +1 05/30/22, 16:08

  38. Simon Schaufelberger rebased onto patch set 15 08/03/22, 16:22

  39. Simon Schaufelberger voted on patch set 15 V +1 CR +1 08/03/22, 16:23

  40. core-ci voted on patch set 15 V +1 08/03/22, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29798

  41. Simon Schaufelberger rebased onto patch set 16 09/21/22, 23:21

  42. Simon Schaufelberger voted on patch set 16 V +1 CR +1 09/21/22, 23:22

  43. core-ci voted on patch set 16 V +1 09/21/22, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31398

  44. Anja Leichsenring rebased onto patch set 17 10/21/22, 08:48

  45. core-ci voted on patch set 17 V +1 10/21/22, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32567

  46. Anja Leichsenring uploaded patch set 18 10/21/22, 08:56

  47. Anja Leichsenring commented on patch set 18 V +1 10/21/22, 08:57

    FlexFormProcessor.php:111

    this is breaking, isn't it? FlexformProcessor is not internal, so extensions might call the function directly.
  48. core-ci voted on patch set 18 V +1 10/21/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32568

  49. Chris Müller uploaded patch set 19 10/21/22, 09:38

  50. core-ci voted on patch set 19 V +1 10/21/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32572

  51. Stefan Bürk uploaded patch set 20 V +1 11/23/22, 00:17

  52. Stefan Bürk commented on patch set 20 11/23/22, 00:18

    FlexFormProcessor.php:111 Reply

    I think, this was because of the thinking "No additional processing is needed anymore". But I'm here on the same path. This is breaking. If this should really change, this should be properly deprecated to be public/done and removed in v13. On the otherhand, I'm not sure if people used this to apply other DataProcessors afterwards to that - to enrich meta data or something like that. Thus, I would favor thinking about deprecation in a dedicated patch. Change method visibility back to `public`.
  53. core-ci voted on patch set 20 V -1 11/23/22, 00:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34091

  54. Stefan Bürk uploaded patch set 21 V -1 11/23/22, 00:42

  55. core-ci voted on patch set 21 V +1 11/23/22, 00:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34093

  56. Stefan Bürk commented on patch set 21 CR -1 11/23/22, 00:52

    I would like to see this testes as functional test, not as unit test. Otherwise eventual changes in the relations are not finding this as expected data is provided, not what may be really returned. Either transform this or add a additional functional test. Simon, are you up to add functional test for this ?
  57. Simon Schaufelberger commented on patch set 21 11/23/22, 04:03

    Reply

    no, I'm in New Zealand and don't have time for this. sorry.
  1. Simon Schaufelberger commented on patch set 21 11/23/22, 07:43

    FlexFormProcessor.php:130

    the nesting could be reduced by using !isset and "continue"
  2. Stefan Bürk commented on patch set 21 11/23/22, 16:13

    Reply

    I asked "Simon Gilli" ;)
  3. Benni Mack wrote 11/30/22, 09:17

    Removed cc Benni Mack.
  4. Benni Mack commented on patch set 22 CR -1 V +1 12/06/22, 10:49

    Published edit on patch set 21.
  5. core-ci voted on patch set 22 V +1 12/06/22, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34710

  6. Benni Mack rebased onto patch set 23 V +1 03/24/23, 16:46

  7. Benni Mack commented on patch set 23 03/24/23, 16:47

    Anyone up for this? Otherwise I suggest to abandon this patch, it has been flying around for a long time (2 ys) without any progress about the testing topic.
  8. core-ci voted on patch set 23 V +1 03/24/23, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39577

  9. Simon Schaufelberger commented on patch set 23 09/01/23, 18:14

    Reply

    Since Simon Gilli is not working on this, I might accept the challenge ;) What do you see as entry point for the functional test? It's not very clear to me how I should setup a test scenario for this.
  10. Stefan Bürk commented on patch set 23 09/05/23, 09:15

    Reply

    Basically following: * Create a TypoScript with a FLUIDTEMPLATE content object and add a flexform to it. * Prepare the dataset that way that images are referenced. * Add the FlexFormDataProcessor to the content object definition in the TypoScript * provide a fluid template rendering the images in some way * execute a frontend subrequest and parse the response content for the added image tags in the response. Something like that as a kickoff. TBH that's just from mind and how I would try to archieve it. Could not find any similar as functional test yet. Let me know if you are stuck. Otherwise, we may have a call in slack for details on this @Simon Schaufelberger.
  11. Simon Schaufelberger uploaded patch set 24 V +1 09/14/23, 23:07

  12. Simon Schaufelberger commented on patch set 24 09/14/23, 23:13

    Reply

    Thank you, I was successful and have a working test case! Maybe it can be a bit simplified but at least it works ;)

    FlexFormProcessor.php:130 Reply

    Done
  13. core-ci voted on patch set 24 V -1 09/14/23, 23:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46582

  14. Simon Schaufelberger uploaded patch set 25 V -1 09/14/23, 23:38

  15. core-ci voted on patch set 25 V +1 09/14/23, 23:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46583

  16. Simon Schaufelberger uploaded patch set 26 V +1 09/16/23, 13:27

  17. core-ci voted on patch set 26 V +1 09/16/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46624

  18. Stefan Bürk commented on patch set 26 CR -1 09/18/23, 10:18

    on it ...
  19. Stefan Bürk uploaded patch set 27 CR -1 V +1 09/18/23, 10:41

  20. core-ci voted on patch set 27 V +1 09/18/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46653

  21. Stefan Bürk voted on patch set 27 V +1 CR +1 09/18/23, 11:23

  22. Göran Bodenschatz voted on patch set 27 CR +1 09/18/23, 11:46

  23. Simon Schaufelberger voted on patch set 27 V +1 CR +1 09/18/23, 12:36

  24. Stefan Bürk voted on patch set 27 V +2 CR +2 09/18/23, 21:35

  25. Stefan Bürk merged patch set 28 09/18/23, 21:35