Review main Merged

69754[BUGFIX] Unlink temp files in import of ext:impexp

Daniel Haupt CR +2 V +2 Easy +4 −8 updated 07/09/21, 11:41

Commit message

The check that the file is in one of the temporary folders has been
removed, as this check is already done in the unlink method of the
GeneralUtility.

This patch specifically addresses composer based installations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Daniel Haupt uploaded patch set 1 07/07/21, 11:42

  2. core-ci voted on patch set 1 V +1 07/07/21, 11:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13054

  3. Benni Mack voted on patch set 1 CR +1 07/07/21, 12:32

  4. Anja Leichsenring commented on patch set 1 07/08/21, 15:55

    is this really important enough to go to 9.5?
  5. Benni Mack commented on patch set 1 V +1 07/09/21, 09:08

    Reply

    I'd say this is important enough and not as intrusive to break logic.
  6. Oli Bartsch voted on patch set 1 V +1 CR +1 07/09/21, 09:53

  7. Benni Mack voted on patch set 1 V +2 CR +2 07/09/21, 11:41

  8. Benni Mack merged patch set 2 07/09/21, 11:41