Review main Abandoned

69756[WIP][FEATURE] Added method to read tca in different file types.

Geert Boetzkes CR 0 V 0 Expert +1499 −2 updated 06/11/23, 22:55

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1524

  1. Geert Boetzkes uploaded patch set 1 07/07/21, 14:06

  2. core-ci voted on patch set 1 V -1 07/07/21, 14:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13066

  3. Geert Boetzkes uploaded patch set 2 07/07/21, 14:18

  4. core-ci voted on patch set 2 V -1 07/07/21, 14:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13069

  5. Geert Boetzkes uploaded patch set 3 07/07/21, 14:21

  6. Geert Boetzkes uploaded patch set 4 07/07/21, 14:32

  7. core-ci voted on patch set 3 V -1 07/07/21, 14:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13070

  8. core-ci voted on patch set 4 V -1 07/07/21, 14:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13071

  9. Geert Boetzkes uploaded patch set 5 07/07/21, 14:35

  10. Geert Boetzkes uploaded patch set 6 07/07/21, 14:39

  11. Geert Boetzkes uploaded patch set 7 07/07/21, 14:41

  12. Christian Kuhn commented on patch set 5 07/07/21, 14:42

    Hmmm, this may collide with a possible development in v12 - with php 8, we could move away from the array towards an object structure - which would enable for instance validation and auto-completion naturally. having different options for source file types could then add headaches if we want to move into this direction. Maybe we could wait a while to see if v12 goes into this direction and pick up this topic again if there is no further progress?
  13. Geert Boetzkes uploaded patch set 8 07/07/21, 14:42

  14. core-ci voted on patch set 5 V +1 07/07/21, 14:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13072

  15. Geert Boetzkes uploaded patch set 9 07/07/21, 14:50

  16. core-ci voted on patch set 6 V +1 07/07/21, 14:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13073

  17. core-ci voted on patch set 7 V +1 07/07/21, 14:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13074

  18. core-ci voted on patch set 8 V -1 07/07/21, 14:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13075

  19. core-ci voted on patch set 9 V +1 07/07/21, 15:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13077

  20. Oliver Hader commented on patch set 9 07/09/21, 07:53

    Just a side-note and not sure what the JSON-schema shall be used for, but... * columns and properties in TCA can be extended and extension authors can apply their own settings * some properties (e.g. `type=USER` and/or `userFunc`) can use arbitrary property names and types * applying logical structure (in terms of "entities") and using `$ref` in JSON-schema allows to reuse schema parts (→ see https://json-schema.org/understanding-json-schema/structuring.html#ref)
  21. Benni Mack wrote 11/29/21, 10:11

    Change destination moved from master to main
  22. Benni Mack updated the commit message in patch set 10 11/29/21, 13:33

  23. Christian Kuhn commented on patch set 10 06/11/23, 22:55

    hey. This patch is pending for 2 years without anyone taking care. There is little to no further information on a concept on this, the main api to TCA is and always has been php, and I think this should be kept as long as this is discussed and decided on a broader level. As such, I'll abandon here for now.
  24. Christian Kuhn abandoned the change 06/11/23, 22:55