Review main Merged

69799[TASK] Allow to distinguish between file and folder rows in FileList

Oli Bartsch CR +2 V +2 Normal +67 −55 updated 07/12/21, 14:43

Commit message

To allow further improvements of the FileList, it is
important to be able to distinguish between file and
folder rows.

This is done by adding data attributes to the corresponding
table rows. Besides the type (file or folder), also relevant
identifiers, e.g. folder identifier or sys_file uid, are added.

Additionally the addElement() method, building the table
rows, is cleaned up as it was obviously just copied from
DatabaseRecordList and therefore contained a lot of unused
and - in this context - wrong functionality (e.g. fetching a
possible l10n_parent from the data array).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 07/09/21, 16:54

  2. core-ci voted on patch set 1 V +1 07/09/21, 17:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13161

  3. Oli Bartsch uploaded patch set 2 07/09/21, 18:38

  4. core-ci voted on patch set 2 V +1 07/09/21, 18:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13163

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 07/09/21, 19:54

  6. Oli Bartsch commented on patch set 2 V 0 CR 0 07/09/21, 19:56

    Wrong patch..
  7. Benni Mack voted on patch set 2 V +1 CR +1 07/09/21, 22:01

  8. Jochen Roth voted on patch set 2 V +1 CR +1 07/12/21, 14:06

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 07/12/21, 14:43

  10. Oli Bartsch merged patch set 3 07/12/21, 14:43