Review main Merged

69808[BUGFIX] Fix missing closing divs in SelectSingleBoxElement

Nikita Hovratov CR +2 V +2 Easy +3 −1 updated 07/12/21, 12:54

Commit message

Under certain conditions closing divs were missing:

1. When all fieldControls are disabled.
2. If the field itself is disabled.

This fixes these cases, so we have correct html at all times.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Nikita Hovratov uploaded patch set 1 07/11/21, 09:29

  2. core-ci voted on patch set 1 V +1 07/11/21, 09:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13186

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 07/11/21, 10:14

  4. Benni Mack voted on patch set 1 V +2 CR +2 07/12/21, 12:54

  5. Benni Mack merged patch set 2 07/12/21, 12:54