Review main Abandoned

69912[BUGFIX] Keep invalid items selected in TcaSelectItems

Georg Ringer CR 0 V 0 Easy +10 −10 updated 04/16/25, 16:01

Commit message

If a value becomes invalid, it should be still be selected to avoid
changed data when persisting a record.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 2133

Show 58 earlier messages
  1. Georg Ringer uploaded patch set 1 07/18/21, 07:20

  2. Georg Ringer commented on patch set 1 07/18/21, 07:20

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 07/18/21, 07:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13427

  4. Benni Mack rebased onto patch set 2 11/03/21, 17:32

  5. core-ci voted on patch set 2 V -1 11/03/21, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18807

  6. core-ci commented on patch set 2 11/04/21, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18807

  7. Anja Leichsenring commented on patch set 2 11/04/21, 10:02

    Unit Tests fail now. Mind to fix them? This also hints on breaking behavior, so we might want to drop the 10.4 from releases.
  8. Oli Bartsch commented on patch set 2 11/17/21, 20:52

    Reply

    It seems the current behaviour was intended according to https://review.typo3.org/c/Packages/TYPO3.CMS/+/44540/, since this patch adjusted exactly the same tests, which are now failing.
  1. Benni Mack updated the commit message in patch set 3 11/18/21, 10:50

  2. core-ci voted on patch set 3 V -1 11/18/21, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19487

  3. Benni Mack wrote 11/29/21, 10:18

    Change destination moved from master to main
  4. Benni Mack updated the commit message in patch set 4 11/29/21, 14:07

  5. core-ci voted on patch set 4 V -1 11/29/21, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20099

  6. Benni Mack updated the commit message in patch set 5 V -1 05/03/23, 09:15

  7. core-ci voted on patch set 5 V -1 05/03/23, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41385

  8. Simon Schaufelberger uploaded patch set 6 V -1 08/21/23, 20:32

  9. core-ci voted on patch set 6 V -1 08/21/23, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45657

  10. Simon Schaufelberger uploaded patch set 7 V -1 08/22/23, 08:46

  11. core-ci voted on patch set 7 V +1 08/22/23, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45663

  12. Simon Schaufelberger voted on patch set 7 CR +1 04/20/24, 23:49

  13. Benni Mack updated the commit message in patch set 8 CR +1 V +1 10/18/24, 13:28

  14. core-ci voted on patch set 8 V -1 10/18/24, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67968

  15. Simon Schaufelberger rebased onto patch set 9 V -1 10/21/24, 10:35

  16. core-ci voted on patch set 9 V +1 10/21/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68294

  17. Simon Schaufelberger rebased onto patch set 10 V +1 12/06/24, 12:09

  18. core-ci voted on patch set 10 V +1 12/06/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70702

  19. Simon Schaufelberger rebased onto patch set 11 V +1 03/27/25, 19:31

  20. core-ci voted on patch set 11 V +1 03/27/25, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76495

  21. Simon Schaufelberger voted on patch set 11 CR +1 V +1 03/28/25, 10:58

  22. Simon Schaufelberger commented on patch set 11 03/28/25, 10:58

    Reply

    Done
  23. Benni Mack commented on patch set 11 CR -1 04/14/25, 12:29

    what about Oli's comment here? I think we re-open another issue then... https://review.typo3.org/c/Packages/TYPO3.CMS/+/44540
  24. Simon Schaufelberger commented on patch set 11 04/15/25, 08:40

    Reply Unresolved

    Ok, it seams like this issue has already been solved in a different patch. Do you think we can abandon this one then?
  25. Benni Mack abandoned the change 04/16/25, 16:01

    won't do