Review main Abandoned

69954[WIP][TASK] Avoid client side JS HTML sanitization

Helmut Hummel CR 0 V 0 Normal +228 −5 updated 12/19/24, 18:07

Commit message

https://review.typo3.org/c/Packages/TYPO3.CMS/+/69767

Review

  • Code review CR 0
  • Verified V 0

Files 3

Review log 1115

  1. Helmut Hummel uploaded patch set 1 07/19/21, 13:49

  2. Helmut Hummel updated the commit message in patch set 2 07/19/21, 13:50

  3. Helmut Hummel uploaded patch set 3 07/19/21, 13:56

  4. core-ci voted on patch set 1 V -1 07/19/21, 14:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13499

  5. core-ci voted on patch set 2 V -1 07/19/21, 14:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13500

  6. core-ci voted on patch set 3 V -1 07/19/21, 14:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13503

  7. Benni Mack wrote 11/29/21, 10:10

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 4 11/29/21, 13:30

  9. Oliver Hader commented on patch set 4 11/29/21, 15:15

    What was the motivation for this change? Can you please provide some more context? Thanks in advance!
  10. core-ci voted on patch set 4 V -1 11/29/21, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20041

  11. Helmut Hummel commented on patch set 4 03/01/23, 15:57

    Reply

    The motivation is to avoid custom home brewed JS HTML sanitisation. It most certainly contains flaws and for sure implements it differently than browsers, because browsers encode differently based on context. therefore using browser API (in this case using text() instead of html() is always to be preferred.
  12. Benni Mack updated the commit message in patch set 5 V -1 05/03/23, 09:33

  13. Benni Mack updated the commit message in patch set 6 10/18/24, 14:06

  14. Christian Kuhn commented on patch set 6 12/19/24, 18:07

    hey. i hope it is ok to abandon here for the time being: this change has been pushed in 2021 without any further work or documented goal, and it seems there is little work happening to get this finished. we can resurrect any time in case work continues.
  15. Christian Kuhn abandoned the change 12/19/24, 18:07