Review 10.4 Merged

70018[BUGFIX] Extbase ObjectManager can inject PSR ContainerInterface

Christian Kuhn CR +2 V +2 Normal +66 −0 updated 07/21/21, 14:39

Commit message

Legacy Extbase ObjectManager has a symfony DI compiler pass
that registers all DI registered "Foo"Interface aliases
via registerImplementation in Extbase container, too.

This however only works if the target is a class.
The Psr/Container/ContainerInterface is a magic
'service_container' alias, though. In turn, ObjectManager
fails to inject Psr/Container/ContainerInterface.

The patch adds this interface explicitly and adds a
functional test to make sure it works.

We target that patch to both v11 and v10 to simplify
the transition from ObjectManager to symfony based DI.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 3