7005[BUGFIX] t3lib_extMgm::addToAllTCAtypes broken
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 11
-
Mario Rimann commented on patch set 1 04/07/13, 09:18
I've just forwarded Joey's patch from the bugtracker to Gerrit. -
Tolleiv Nietsch commented on patch set 2 04/07/13, 09:18
Do not submit Please provide appropriate unittests and make sure that the patch sources don't break existing ones. -
Mario Rimann commented on patch set 3 04/07/13, 09:18
Fails @Tolleiv: I just rebased the change and extended the releases-line to contain "6.0". But it seems this change breaks the existing unit-tests (just run on master + this change). Since I just pushed this change into the review process but the patch is not from me, I don't have a clue how to a) test the new behaviour b) fix the existing unit tests I'd be really happy if someone else could jump in and help out with this one. -
Mario Rimann uploaded patch set 3 04/07/13, 09:18
-
Mario Rimann commented on patch set 3 04/07/13, 09:18
@Tolleiv: How should we go on with this? -
Markus Klein commented on patch set 2 04/07/13, 09:18
Commit message fix. -
Markus Klein uploaded patch set 2 04/07/13, 09:18
-
Mr. Jenkins commented on patch set 1 04/07/13, 09:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2569/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/07/13, 09:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2787/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/07/13, 09:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4906/ : SUCCESS -
Steffen Ritter commented on patch set 3 04/07/13, 09:18
Abandoned Nothing happened in 1.5 year and the creator of the patch seems not to be intereted into improving...