Review main Abandoned

7005[BUGFIX] t3lib_extMgm::addToAllTCAtypes broken

Mario Rimann CR 0 V 0 Easy +18 −13 updated 06/03/13, 20:49

Commit message

Fixes t3lib_extMgm::addToAllTCAtypes to work with an empty
third parameter so that the added field is placed at the right
position as it was intended.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 11

  1. Mario Rimann commented on patch set 1 04/07/13, 09:18

    I've just forwarded Joey's patch from the bugtracker to Gerrit.
  2. Tolleiv Nietsch commented on patch set 2 04/07/13, 09:18

    Do not submit Please provide appropriate unittests and make sure that the patch sources don't break existing ones.
  3. Mario Rimann commented on patch set 3 04/07/13, 09:18

    Fails @Tolleiv: I just rebased the change and extended the releases-line to contain "6.0". But it seems this change breaks the existing unit-tests (just run on master + this change). Since I just pushed this change into the review process but the patch is not from me, I don't have a clue how to a) test the new behaviour b) fix the existing unit tests I'd be really happy if someone else could jump in and help out with this one.
  4. Mario Rimann uploaded patch set 3 04/07/13, 09:18

  5. Mario Rimann commented on patch set 3 04/07/13, 09:18

    @Tolleiv: How should we go on with this?
  6. Markus Klein commented on patch set 2 04/07/13, 09:18

    Commit message fix.
  7. Markus Klein uploaded patch set 2 04/07/13, 09:18

  8. Mr. Jenkins commented on patch set 1 04/07/13, 09:18

  9. Mr. Jenkins commented on patch set 2 04/07/13, 09:18

  10. Mr. Jenkins commented on patch set 3 04/07/13, 09:18

  11. Steffen Ritter commented on patch set 3 04/07/13, 09:18

    Abandoned Nothing happened in 1.5 year and the creator of the patch seems not to be intereted into improving...