Review main Merged

70055[BUGFIX] Clarify IPv6 address matching

Sybille Peters CR +2 V +2 Easy +5 −4 updated 07/30/21, 11:19

Commit message

When matching IPv6 addresses (for example in IPmaskList)
appending the address with * as wildcards will not work.
The function GeneralUtility::cmpIPv6() uses validIPv6()
which will fail on an address with *.

Using addresses with CIDR-notation, will work for both
IPv4 and IPv6 addresses (e.g. 2001:0DB8:1234::/48,
192.16.0.0/16).

The description of TYPO3_CONF_VARS and comments for the
function in GeneralUtility is updated accordingly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Sybille Peters uploaded patch set 1 07/22/21, 17:37

  2. core-ci voted on patch set 1 V +1 07/22/21, 17:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13678

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 07/29/21, 20:47

  4. Jochen Roth voted on patch set 1 CR +1 07/30/21, 07:35

  5. Jochen Roth voted on patch set 1 V +1 07/30/21, 07:35

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 07/30/21, 11:19

  7. Christian Kuhn merged patch set 2 07/30/21, 11:19