Review main Merged

70171[BUGFIX] Remove DataHandler->newlog() functionality

Benni Mack CR +2 V +2 Normal +92 −107 updated 08/03/21, 17:25

Commit message

This change removes the internal "newlog()" method
from DataHandler. All occurrences are replaced
by DataHandler->log() methods, which newlog() acted as
a wrapper for it.

The main downside of newlog() is that the connection
to the actual record (when writing to sys_log) is lost,
and no contextual information is kept.

This change solves that problem by properly setting
the table and record uid to the log method.

The main usages for DataHandler->newlog() are
put into localization and workspaces/versionable
handling. where the "action" is currently set
to SystemLogGenericAction::UNDEFINED, because
there is no specific type for them. Specific action
types have been added for localize, versionize and
publishing.

The next step in this line of patches are:
* Clean up the labels by always using %s or {} for replacements.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5