Review main Merged

70201[BUGFIX] Ensure correct merge of update suggestions

Simon Gilli CR +2 V +2 Easy +1 −1 updated 08/12/21, 16:10

Commit message

The calls to the getUpdateSuggestions() method may result
in the same change is added twice to the same hash. Using
array_replace_recursive() ensures the same two suggestions
are merged correctly and not as array of strings like done
by the former implementation.

This is important for sqlite which creates multiple
statements for one 'job' sometimes.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1